Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added caching and ccaching to CI and synced with habitat-api #110

Merged
merged 1 commit into from
Jul 18, 2019

Conversation

mathfac
Copy link
Contributor

@mathfac mathfac commented Jul 17, 2019

  • Added caching to CI and synced with habitat-api.
  • Added smoke test for training of baselines
  • Fixed Pytorch caching installation and habitat-api
  • Added ccaching to speed up build: it should fall back to master branch ccache for new branches. (https://circleci.com/docs/2.0/caching/#source-caching)

Full testing drops from 18 minutes to 9 minutes(2x times) for second run. That will help run testing on same PR faster.
Build step drops from 5 minutes to 2 minutes(2x times) with ccache usage

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jul 17, 2019
@erikwijmans
Copy link
Contributor

We've been using https://github.com/facebookresearch/habitat-sim/blob/master/pyproject.toml to keep the args for isort

@mathfac mathfac force-pushed the circleci_sync branch 4 times, most recently from 2badb9f to f5d74c6 Compare July 17, 2019 22:13
@mathfac mathfac changed the title Added caching to CI and synced with habitat-api Added caching and ccaching to CI and synced with habitat-api Jul 17, 2019
@mathfac
Copy link
Contributor Author

mathfac commented Jul 17, 2019

Full testing and caches updates take 18 minutes, while second run using caches 9 minutes.
Build step drops from 5 minutes to 2 minutes with ccache usage, mostly because downloading and rebuilding dependencies. Cached CI run.

Copy link
Contributor

@erikwijmans erikwijmans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mathfac mathfac merged commit 2c00009 into master Jul 18, 2019
@mathfac mathfac deleted the circleci_sync branch July 18, 2019 00:32
eundersander pushed a commit to eundersander/habitat-sim that referenced this pull request Aug 6, 2020
SimulatorActions is no longer an enum. It is an extendable singleton. It allows you to extend the action space but it is quite strict about it. Actions cannot be put on different ints, actions cannot be remove.
There is now a registry for action space configurations.
Ram81 pushed a commit to Ram81/habitat-web-sim that referenced this pull request Dec 10, 2020
* Added caching to CI and synced with habitat-api.
* Added smoke test for training of baselines
* Fixed Pytorch caching installation and habitat-api
* Added ccaching to speed up build: it should fall back to master branch ccache for new branches
* Full testing drops from 18 minutes to 9 minutes(2x times) for second run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants